fix: remove deprecated 0-keys placeholder behavior #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Meier <ben.meier@humanitec.com>
astromechza
requested review from
johanneswuerbach,
delca85,
docktorrr,
mathieu-benoit,
mateuszjenek,
chrishumanitec and
sujaya-sys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some behavior inherited from an older version of score-compose that resolved 2 part placeholders like
${resources.<name>}to<name>. This was used as a mechanism to refer to certain resources in some contexts (like volumes). A similar mechanism exists in some parts of Humanitec's implementation.This funcitonality was ported over to score-go, but can now be removed and any special behavior can be moved into the implementations respectively.
As an aside this PR also fixes some comments in other places that were incorrect.
This is what the score-compose PR would look like: score-spec/score-compose#103