feat: support extra state on resources #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ben Meier <ben.meier@humanitec.com>
Signed-off-by: Ben Meier <ben.meier@humanitec.com>
astromechza
force-pushed
the
resource-state
branch
from
92b8f71
to
9d313c7
Compare
astromechza
requested review from
johanneswuerbach,
delca85,
docktorrr,
mathieu-benoit,
Nilsty,
mateuszjenek and
sujaya-sys
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some Score implementations need to store some additional and custom data on the "resource" that isn't associated with the existing outputs or state. For example in score-k8s we may need to store a uuid associated with each resource or other lifecycle and status information that isn't part of the mutating "state" of the resource. Or we may need to store the Manifests generated by score-k8s provisioners.
We also fix a small issue causing a small panic in some tests and development efforts.