chore(placeholders): refactor matching capture and add regression test #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astromechza
force-pushed
the
placeholder-escape-specialisation
branch
from
feb47e6
to
c0660cd
Compare
astromechza
requested review from
delca85,
docktorrr,
mathieu-benoit,
chrishumanitec and
sujaya-sys
Signed-off-by: Ben Meier <ben.meier@humanitec.com>
astromechza
force-pushed
the
placeholder-escape-specialisation
branch
from
c0660cd
to
81afe55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds supporting functionality for score-compose# by allowing the unescape functionality to be customized. This convers the substituter into a struct which will support any further parameterized substitution in the future.