Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added common uriget package for fetching provisioners #45

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

astromechza
Copy link
Member

I'd like to add a flag to the score-compose and score-k8s init subcommands for loading external provisioner files. This should mean that the user no longer needs to access the .score-xyz state directory themselves since this can be considered internal behavior.

We want to be able to pull in provisioners from the local filesystem, git, or http, so this uriget package supports this and provides an interface for reading files in this way. The git support calls the git binary on the system. This avoids needing a built in heavyweight client library and means we can take advantage of any auth sockets or global config.

Examples:

score-compose init \
	--provisioners https://raw.githubusercontent.com/user/repo/public-provisioner/provisioners.yaml \
	--provisioners custom-provisioners.yaml \
    --provisioners git-ssh://git@github.com/score-spec/score-compose-provisioners/example.yaml

Signed-off-by: Ben Meier <ben.meier@humanitec.com>
Copy link

@mathieu-benoit mathieu-benoit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Enriching the Developer experience and workflow to get external provisioners.

Answering this need: score-spec/score-compose#141.

What about supporting OCI image? https://opencontainers.org/ I can do for example oras push|pull with the provisioners.

@astromechza
Copy link
Member Author

Great! Enriching the Developer experience and workflow to get external provisioners.

Answering this need: score-spec/score-compose#141.

What about supporting OCI image? opencontainers.org I can do for example oras push|pull with the provisioners.

Maybe later, this library at least creates a place where that would go.

@astromechza astromechza merged commit 0e2d22d into main Sep 9, 2024
4 checks passed
@astromechza astromechza deleted the urigetter branch September 9, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants