Skip to content
This repository has been archived by the owner on Jul 4, 2024. It is now read-only.

Improved humanitec error handling #64

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Improved humanitec error handling #64

merged 2 commits into from
Nov 13, 2023

Conversation

johanneswuerbach
Copy link
Contributor

@johanneswuerbach johanneswuerbach commented Nov 13, 2023

Improved error handling by validating the provided IDs locally and by including the returned API response in error messages.

Fixes #63

Description

What does this PR do?

Users often mixup name and id, to prevent confusion the id is validated locally.

Additionally API error messages are now included in the output as those often provide more details how to resolve an issue.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • New chore (expected functionality to be implemented)

Checklist:

  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I've signed off with an email address that matches the commit author.

Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>
Signed-off-by: Johannes Würbach <johannes.wuerbach@googlemail.com>
Copy link

@mateuszjenek mateuszjenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Member

@astromechza astromechza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@johanneswuerbach johanneswuerbach merged commit 0cf7c6a into main Nov 13, 2023
3 checks passed
@johanneswuerbach johanneswuerbach deleted the err-details branch November 13, 2023 12:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Humanitec deployment error message not surfaced in Score
3 participants