Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide audio slider, add microphone slider, add system tray, scroll through workspaces and AMD GPU #5

Closed
linuxmobile opened this issue Jan 29, 2023 · 27 comments · Fixed by #12
Labels
enhancement New feature or request

Comments

@linuxmobile
Copy link

linuxmobile commented Jan 29, 2023

The bar really consumes very little, I loved it. Even less than waybar, in my case.

  • I think you could add a systray. Since I can see the telegram and discord icons.

  • You could also add that the volume icon opens the slider with a hover and not that it is always open.

  • Mic slider with hover effect to open the slider too.

  • Switch Workspaces with scroll (hyprctl dispatch workspace e+1 & hyprctl dispatch workspace e-1)

(an another little things, i've got amd gpu. If you can add this too i will love you a lot <3)

@scorpion-26
Copy link
Owner

scorpion-26 commented Jan 29, 2023

In regards to the amd gpu:
Since I don't have an AMD gpu, can you confirm, that the files mentioned in https://unix.stackexchange.com/questions/576707/how-to-monitor-amd-gpu-on-linux-server exist? If so, can you post the output of them(with cat)?

add a systray

That should be possible. Unfortunately, I'm currently quite busy, so it could be a while(~1 Month) until I can get around to implement such a major feature.

You could also add that the volume icon opens the slider with a hover and not that it is always open.

That is intended behaviour, but I probably can add a config option for that.

Mic slider with hover effect to open the slider too.

Should be possible. Since I don't have a microphone ready, I probably need some feedback if it works.

Switch Workspaces with scroll

Should also be possible

@scorpion-26 scorpion-26 added the enhancement New feature or request label Jan 29, 2023
@scorpion-26 scorpion-26 changed the title [FEATURE REQUEST] Mic slider & Sys tray Mic slider & Sys tray Jan 29, 2023
@scorpion-26 scorpion-26 changed the title Mic slider & Sys tray Hide audio slider, add microphone slider, add system tray, scroll through workspaces and AMD GPU Jan 29, 2023
@linuxmobile
Copy link
Author

https://unix.stackexchange.com/questions/576707/how-to-monitor-amd-gpu-on-linux-server exist? If so, can you post the output of them(with cat)?

image

And again. Thx for the work. i love it

@scorpion-26
Copy link
Owner

Am I right to conclude, that you have 2GiB VRAM? (So I know in which unit the VRAM is measured. I assume, it is in bytes)

@linuxmobile
Copy link
Author

Am I right to conclude, that you have 2GiB VRAM? (So I know in which unit the VRAM is measured. I assume, it is in bytes)

Yeah, ive got 2gb

scorpion-26 added a commit that referenced this issue Jan 30, 2023
Partially implements #5
The spammy logs will remain, until it is confirmed, that it works.
@scorpion-26
Copy link
Owner

I've just added a first implementation of the AMD GPU status. Since I can't test it, I would appreciate it, if you can test it:
For that, can you do the following:
Pull the latest commit

Completely remove all build files and rebuild

rm -rf build
meson setup build
ninja -C build
build/gBar bar 0

Everything except the temperature should work. If it doesn't (e.g. crash), please attach the log.

I also need some more information about the temperature:

cat /sys/class/drm/card0/device/hwmon/hwmon*/temp1_input
cat /sys/class/drm/card0/device/hwmon/hwmon*/temp1_label

Thanks!

@linuxmobile
Copy link
Author

cat /sys/class/drm/card0/device/hwmon/hwmon*/temp1_input
cat /sys/class/drm/card0/device/hwmon/hwmon*/temp1_label

Gpu module is working now. Thx u <3

image

@scorpion-26
Copy link
Owner

one last thing: can you ls /sys/class/drm/card0/device/hwmon/?

@linuxmobile
Copy link
Author

image

Ask me what you need!

scorpion-26 added a commit that referenced this issue Jan 30, 2023
That should be it for the AMD GPU part of #5
@scorpion-26
Copy link
Owner

AMD should work now, just like Nvidia

@linuxmobile
Copy link
Author

linuxmobile commented Jan 30, 2023

just like Nvidia

Let me rebuild & perfect!! Is working without problems!

scorpion-26 added a commit that referenced this issue Feb 4, 2023
This adds an option to hide the audio slider behind a revealer, which
works similar to the sensors.
For the ping: #5
@scorpion-26
Copy link
Owner

scorpion-26 commented Feb 4, 2023

You could also add that the volume icon opens the slider with a hover and not that it is always open.

Just added that. To enable it, just add AudioRevealer: true to your config

@linuxmobile
Copy link
Author

linuxmobile commented Feb 4, 2023

You could also add that the volume icon opens the slider with a hover and not that it is always open.

Just added that. To enable it, just add AudioRevealer: true to your config

Let me try!

Edit: Nice it work perfect!

scorpion-26 added a commit that referenced this issue Feb 12, 2023
Scrolling the workspace widgets now scroll through the workspaces. The
exact behaviour is governed by
'WorkspaceScrollOnMonitor'(either 'm[+/-]1' or 'e[+/-]1'). The direction
can be inverted with 'WorkspaceScrollInvert'.

For the ping: #5
@scorpion-26
Copy link
Owner

Switch Workspaces with scroll (hyprctl dispatch workspace e+1 & hyprctl dispatch workspace e-1)

Just implemented the workspace scroll. By default it calls now m+1 and m-1, but that can be changed by setting WorkspaceScrollOnMonitor: false in the config (Then it'll call e+1 and e-1). The scroll direction can be inverted using WorkspaceScrollInvert: true.

@linuxmobile
Copy link
Author

build/gBar bar 0

I do a rebuild

rm -rf build
meson setup build
ninja -C build
build/gBar bar 0

and now i got this issue:
image

@scorpion-26
Copy link
Owner

Oh, you need to either set the name of your network adapter in the config ("NetworkAdapter") or disable it by setting NetworkWidget to false in the config.
I forgot to do a check, my bad.

@scorpion-26
Copy link
Owner

scorpion-26 commented Feb 12, 2023

It should work now on the latest commit, even without changing the config

meson setup build

By the way, you probably want to run meson setup build -Dbuildtype=release instead for everyday use builds, as it compiles with optimizations.

@linuxmobile
Copy link
Author

NetworkWidget

Oh. I forgot to tell you yes. Everything works perfect!

Just to update the checklist. would be missing:

  • Mic slider (with hover effect)
  • systray

And I find a small issue with the volume slider. I prefer that the volume % would be configurable. For example, if I want it to go up or down by 5% that can be configured. Since the percentage currently seems irrational. The first step is 15% (controlled with pavucontrol).

scorpion-26 added a commit that referenced this issue Feb 20, 2023
There seems to be a floating point error somewhere though, since
sometimes it goes up by AudioScrollSpeed - 1 instead of
AudioScrollSpeed...

For the ping #5
@scorpion-26
Copy link
Owner

Oh. I forgot to tell you yes. Everything works perfect!

Glad to hear that!

Mic slider (with hover effect)

What do you mean by hover effect? Like reveal on hover or with flyin-support?

I prefer that the volume % would be configurable.

Now done, configurable via AudioScrollSpeed in the config. Note however, that there seems to be a precision error, causing it to sometimes jump up by e.g. 4 instead of the configured 5. If that's a problem, let me know.

@linuxmobile
Copy link
Author

If that's a problem, let me know.

It's working fine. But even from 0 to 15% is fine. From 15% it goes to 19%, from 19 to 24%, from 24 to 29%, 29% to 33%, from 33 to 38%. But it isn't a real problem. Thx for fix everything!

scorpion-26 added a commit that referenced this issue Feb 22, 2023
This commit adds a new widget for the bar: A Microphone widget. It is
disabled by default and can can
be enabled with AudioInput: true.
Implements a flyin as well.

#5 for the ping
@scorpion-26
Copy link
Owner

scorpion-26 commented Feb 22, 2023

Mic slider with hover effect to open the slider too.

Now done. Note that you need to set AudioInput to true and add .mic-icon / .mic-volume to the css. You can see the diff for reference.

@linuxmobile
Copy link
Author

linuxmobile commented Feb 23, 2023

Now done. Note that you need to set AudioInput to true and add .mic-icon / .mic-volume to the css. You can see the diff for reference.

Everything works fine, but the volume icons now do not appear for me. It's probably because of the font I'm using.

image

Check font i'm using:

image

@scorpion-26
Copy link
Owner

scorpion-26 commented Feb 23, 2023

I use the 'Material Design' Icons from Nerd Font for the volume icons. Since version 2.3.0 the old locations were deprecated in favor of new locations. I use the new ones. So you probably need to update the version of the Nerd Font (Or use a more up to date nerd font just for those icons using css, while using your old font for the rest).

scorpion-26 added a commit that referenced this issue Mar 17, 2023
Implements a rough outline of the SNI (StatusNotifierItem) d-bus
protocol for tray icons.

Note: This is currently *very* WIP

Full implementation will close #5
@scorpion-26
Copy link
Owner

scorpion-26 commented Mar 17, 2023

I think you could add a systray. Since I can see the telegram and discord icons.

I finally got around to implementing something. Tested for discord, telegram and steam. With the current implementation there should be icons appearing on the bar out-of-the-box (Even though they are all over the place). Note that the implementation is by no means complete. Bugs/Issues regarding this feature should be posted on the PR I opened, since progress tracking happens there.

@linuxmobile
Copy link
Author

Bugs/Issues regarding this feature should be posted on the PR I opened, since

Is it necessary to add something in the config file to show the telegram and discord icons? They don't show up...

@scorpion-26
Copy link
Owner

scorpion-26 commented Mar 22, 2023

git checkout sni, you should then be on commit 7f22f01, which you can check with git log
Since it is not ready yet, it is in the sni branch (See PR).
Then build and run normally.

scorpion-26 added a commit that referenced this issue May 3, 2023
Implements a rough outline of the SNI (StatusNotifierItem) d-bus
protocol for tray icons.

Note: This is currently *very* WIP

Full implementation will close #5
scorpion-26 added a commit that referenced this issue May 4, 2023
Implements a rough outline of the SNI (StatusNotifierItem) d-bus
protocol for tray icons.

Note: This is currently *very* WIP

Full implementation will close #5
scorpion-26 added a commit that referenced this issue May 4, 2023
Implementation for SNI (StatusNotifierItem) d-bus protocol for tray
icons.

Implements #5
@scorpion-26
Copy link
Owner

SNI support has been merged. You can see the updated FAQ for some common issues. Note that you may need to run git submodule update --init before building.

@ThatOneCalculator
Copy link

Now done. Note that you need to set AudioInput to true and add .mic-icon / .mic-volume to the css. You can see the diff for reference.

Everything works fine, but the volume icons now do not appear for me. It's probably because of the font I'm using.

image

Check font i'm using:

image

Totally unrelated, but how did you make those screenshots?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants