Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard page #14

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Dashboard page #14

merged 4 commits into from
Nov 29, 2023

Conversation

coryrpow
Copy link
Collaborator

Cory Wrote Tests

Necessary checkmarks:

[x] All Tests are Passing

[x] The code will run locally

Type of change

[x] New feature
[] Bug Fix

Implements/Fixes:

I added testing for the Dashboard page as well as the discover page routing. I took the discover page to be a movie related thing and named the controller movies, but we can always refactor if we change our minds on that. I had an annoying time working around the rubocop gem, not sure if you did as well, but I think that will be something to refactor and keep up with just to avoid the demonic little blue squiggles all over.

I also removed a line of code in the index_spec that related to checking for an email to be present in the show spec, as it didn't call for it.

Check the correct boxes

[x] This broke nothing
[] This broke some stuff
[] This broke everything

Testing Changes

[] No Tests have been changed
[x] Some Tests have been changed
[] All of the Tests have been changed(Please describe what in the world happened)

Checklist:

[] My code has no unused/commented out code
[x] I have reviewed my code
[] I have commented my code, particularly in hard-to-understand areas
[x] I have fully tested my code

(For Fun!)Please Include a link to a gif of your feelings about this branch

Link:

… The show page user story doesn't call for the email so I just removed it and removed the corresponding line in the test.
…ith a movies controller, a movies view folder, a movies index page, and routing for the discover page corresponding to a specific user.
… was being clever doing a movies_controller, but I think the movies have to be a different thing and discover seems to be its own thing. So changed it to discover#index/controller.
Copy link
Owner

@scottdevoss scottdevoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Although, I am not quite sure what you mean with your rubocop-rails issue. Let's discuss next time we meet. Good work!

@scottdevoss scottdevoss merged commit d435f8c into main Nov 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants