Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor #28

Merged
merged 12 commits into from
Dec 1, 2023
Merged

Refactor #28

merged 12 commits into from
Dec 1, 2023

Conversation

coryrpow
Copy link
Collaborator

@coryrpow coryrpow commented Dec 1, 2023

Cory Implemented /Reviewed

Neccesary checkmarks:

[x] All Tests are Passing

[x] The code will run locally

Type of change

[] New feature
[] Bug Fix

Implements/Fixes:

Added to the README to include Scott's contribution to the presentation and (hopefully) fixed the issue with coverage. I also refactored a test in the movie_results/show_spec to have within blocks and be a little more dynamic and check each movie's title link and average rating show up in the same section id in the same test.

Check the correct boxes

[x] This broke nothing
[] This broke some stuff
[] This broke everything

Testing Changes

[] No Tests have been changed
[x] Some Tests have been changed
[] All of the Tests have been changed(Please describe what in the world happened)

Checklist:

[] My code has no unused/commented out code
[x] I have reviewed my code
[] I have commented my code, particularly in hard-to-understand areas
[x] I have fully tested my code

(For Fun!)Please Include a link to a gif of your feelings about this branch

Link:

@coryrpow coryrpow merged commit 87fdd9e into main Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants