Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New viewing party page #31

Merged
merged 6 commits into from
Dec 2, 2023
Merged

New viewing party page #31

merged 6 commits into from
Dec 2, 2023

Conversation

coryrpow
Copy link
Collaborator

@coryrpow coryrpow commented Dec 2, 2023

X Wrote Tests X Implemented X Reviewed

Neccesary checkmarks:

[x] All Tests are Passing

[x] The code will run locally

Type of change

[x] New feature
[] Bug Fix

Implements/Fixes:

Final push before the presentation video. Didn't get to finish this US or the final US but feel good about the testing and where it's all at.

Check the correct boxes

[x] This broke nothing
[] This broke some stuff
[] This broke everything

Testing Changes

[] No Tests have been changed
[x] Some Tests have been changed
[] All of the Tests have been changed(Please describe what in the world happened)

Checklist:

[] My code has no unused/commented out code
[x] I have reviewed my code
[] I have commented my code, particularly in hard-to-understand areas
[] I have fully tested my code

(For Fun!)Please Include a link to a gif of your feelings about this branch

Link:

…nd added some private methods in the controller for viewing_party. I remembered the before_action from the final mod 2 project so I'll probably try and implement that elsewhere if I can, but we'll see. Signing off for the night, but going to hit hard tomorrow and do everything I can before we submit
… adding simplecov again, but not sure how to get it to work again. Not a big deal, but was just curious.
…and viewing parties. Also tested the relationships and validations for them in the model tests
…to add other users. I think I know where to go with it next though.
…n viewing party. Also got the form to show users using an if each in the view that I think works? It passes in the test thus far, but the testing suite is taking 10 seconds to load each time so not sure what happened. I assume it's the new migrations but that seems strange as the new migrations are empty tables. Either way, it adds a lot of time to the testing process.
@coryrpow coryrpow merged commit b951fd2 into main Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant