Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Fix undefined libm references. #33

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

orbea
Copy link

@orbea orbea commented Mar 28, 2021

When building flam3 with slibtool (https://dev.midipix.org/cross/slibtool) it fails with many references to libm indicating a missing -lm for libflam3_la_LIBADD. This happens because it uses -no-undefined and GNU libtool does not fail because it silently ignores -no-undefined.

Additionally I moved the dependencies to LIBADD where they should be and removed the -lm from the LDADD variables where its now redundant.

Please see this downstream issue: https://bugs.gentoo.org/779001

gentoo-bot pushed a commit to gentoo/gentoo that referenced this pull request Jun 3, 2021
Upstream-PR: scottdraves/flam3#33
Closes: https://bugs.gentoo.org/779001
Signed-off-by: orbea <orbea@riseup.net>
Signed-off-by: Sam James <sam@gentoo.org>
@orbea
Copy link
Author

orbea commented Aug 4, 2021

@scottdraves Is this project still active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant