Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

optional modules not optional #111

Open
dkebler opened this issue Sep 1, 2017 · 1 comment
Open

optional modules not optional #111

dkebler opened this issue Sep 1, 2017 · 1 comment

Comments

@dkebler
Copy link

dkebler commented Sep 1, 2017

if I install camo with --no-optional. I get this error even though

Error: Cannot find module 'mongodb'
    at Function.Module._resolveFilename (module.js:470:15)
    at Function.Module._load (module.js:418:25)
    at Module.require (module.js:498:17)
    at require (internal/module.js:20:19)
    at Object.<anonymous> (/media/david/dataxfer/lighting/backend/node_modules/camo/lib/clients/mongoclient.js:6:19)

I am not using mongodb and have only in my code

var Document = require('camo').Document;

@stevefranchak
Copy link

stevefranchak commented Mar 20, 2018

I submitted PR #116 to fix this issue.

In the meantime, if you need this change, you can install my fork in your node project with:
npm install --no-optional https://github.com/stevefranchak/camo/tarball/master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants