-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
req: disable/revert the image preview due too heavy in huge data! #467
Comments
OH! is this possible to do? I have a web application with grocery crud but the internet in my country is getting slower, it would be great if instead of thumbnails I would show links ... Any help please! |
thanks to @scoumbourdis as posted in a comment:
i'll try and maybe we can configure a config flag to disable previews! |
…vy in huge data! Grocery_CRUD.php * this alow to only list links in the LIST case of rendering.. * by this way loading of rendering a page in slow connections will able to run in remote cases * later will be provided a patch to able to configure it in /scoumbourdis/grocery-crud/issues/467
doit @scoumbourdis at codeigniterpower@45767c0 please i can make a patch for you repository but said if are able to pull that or i must change something? |
* prepare configure keys at the configure file * make the patch based on comments on oficial repository * inicialize and chek the config variables also when will render fields
Hello @mckaygerhard , Your approach is good and thanks for your code suggestion :) . I will try to find the time to review your code as I will need to do some changes from configurations point of view. I will keep you updated for any news |
if you need that i change something, just tell me.. that pacht are rude maybe.. works for now as preliminar support.. i cant made just now, but later i'll do more if you need to meet your code standart |
The code @mckaygerhard is fine. I was mainly thinking to have one configuration for the preview such as:
and at the code to use the in_array. For example: $preview_file = $is_image && in_array('list', $this->config->grocery_crud_file_upload_image_preview); for 4 main reasons:
What do you think? |
that's obvious .. you have right.. again sorry due in a hurry to easy do the coding i make separate configs options.. so as arrays are better, please if you plant to do something tellme ... |
option to able to disable the image preview! or at leas how to revert that feature available since 1.3
currently images are previewed in list and also in edit and new as per requested in:
https://www.grocerycrud.com/forums/topic/20-image-thumbnail-in-list-page/
that since 1.3.0, but now i want to revert this behavior! how can i do that!
The text was updated successfully, but these errors were encountered: