Revert utcnow change #400
Merged
Revert utcnow change #400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has lead to timezone offsets being sent to the Core Agent, which it doesn't parse, logging this error and failing to return a full response to the client:
```
[2019-11-25T18:09:49][socket::server][INFO] Reading a command from stream: NoParse(Error("trailing input", line: 1, column: 70), "{\"ApplicationEvent\": {\"timestamp\": \"2019-11-25T18:09:49.328081+00:00Z\", \"event_type\": \"CPU/Utilization\", \"event_value\": 0.027687317280944007, \"source\": \"Pid: 69721\"}}")
```
I think the safest thing to do here is a pure revert. It would be better theoretically to track datetimes with timezone information but it seems too disruptive to the way the core agent works.
This was referenced Oct 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #397 has lead to timezone offsets being sent to the Core Agent, which it doesn't parse, logging this error and failing to return a full response to the client:
I think the safest thing to do here is a pure revert. It would be better theoretically to track datetimes with timezone information but it seems too disruptive to the way the core agent works.