Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default Scoverage compiler plugin version #201

Conversation

travisbrown
Copy link
Contributor

The 1.5.0 release of the plugin isn't yet synced to Maven Central, but I just tried depending on the Sonatype releases version, and it seems that I still have to set the coverageScalacPluginVersion or I get the snapshot.

This PR fixes this by updating the default version. /cc @gslowikowski

@gslowikowski
Copy link
Member

Great, it ends this way, when I hurry.

@travisbrown
Copy link
Contributor Author

@gslowikowski No worries, it's easy enough to work around. 😄 Thanks again!

@travisbrown
Copy link
Contributor Author

One other issue, though—the Scoverage runtime doesn't seem to be published for Scala.js on Scala 2.11 (which is causing this PR to fail). It's available for all other version crosses.

It doesn't look like this is just a Maven Central syncing issue, since it's not on Sonatype releases either.

@gslowikowski
Copy link
Member

I see it, this is different issue. With sbt-release this time. I've had network problems, but the release process finished successfully. Now I see java.net.ConnectionException in the log. I will push missing files to Maven central and file bug report for sbt-release plugin.

@gslowikowski gslowikowski merged commit 28905a3 into scoverage:master Nov 7, 2016
@gslowikowski
Copy link
Member

Thank you @travisbrown for spotting the problems. You saved my life. Everything is fixed and synced now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants