Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dateparser] Add feature add_prefer_month_year #1146

Merged
merged 9 commits into from
May 16, 2023
Merged

[dateparser] Add feature add_prefer_month_year #1146

merged 9 commits into from
May 16, 2023

Conversation

adnan-awan
Copy link
Contributor

@adnan-awan adnan-awan commented Feb 27, 2023 •
edited
Loading

Resolves #1042

To do:

  • Add tests for this feature
  • Update the docs

@adnan-awan
[dateparser] Add feature add_prefer_month_year
cd026bb 
- Add check to not apply month correction in case of month is given
- #1042
@adnan-awan
Merge remote-tracking branch 'origin/master' into add-PREFER_MONTH_OF…
20e1744 
…_YEAR-1042

# Conflicts:
#	dateparser/parser.py
@adnan-awan
[dateparser] Add feature add_prefer_month_year
c69d5f7 
- Resolve conflicts and perform isort
- #1042
Gallaecio
Gallaecio approved these changes Mar 27, 2023
View reviewed changes
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@Gallaecio Gallaecio self-requested a review March 27, 2023 12:44
@adnan-awan adnan-awan force-pushed the add-PREFER_MONTH_OF_YEAR-1042 branch from b31c4c4 to 03710f8 Compare April 28, 2023 09:41
Gallaecio
Gallaecio reviewed May 2, 2023
View reviewed changes
Copy link
Member

@Gallaecio Gallaecio left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the testing side, I think it would be good to cover an additional case where the current month has fewer days than the requested month. For example: Input: 2023, Current: April 15th, Preferred: last day, last month, Expected: Dec 31st (i.e. we are making sure it does not cause Dec 30th).

@adnan-awan
[dateparser] Add another test for PREFER_MONTH_OF_YEAR
0814860 
- For example: Input: 2023, Current: April 15th, Preferred: last day, last month, Expected: Dec 31st (i.e. we are making sure it does not cause Dec 30th).
- #1042
@adnan-awan
Copy link
Contributor Author

Thanks @Gallaecio for useful suggestion!

I've added the suggested test. Would you please review it again?

Gallaecio
Gallaecio approved these changes May 3, 2023
View reviewed changes
Copy link
Member

@Gallaecio Gallaecio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@Gallaecio Gallaecio requested a review from serhii73 May 3, 2023 07:13
@Gallaecio Gallaecio merged commit 0056c88 into master May 16, 2023
@adnan-awan adnan-awan deleted the add-PREFER_MONTH_OF_YEAR-1042 branch June 1, 2023 20:14
jimbofreedman pushed a commit to jimbofreedman/dateparser that referenced this pull request Jul 4, 2023
@adnan-awan @jimbofreedman
Add a PREFER_MONTH_OF_YEAR setting (scrapinghub#1146)
f07f28f
@anuj1508
Copy link

@Gallaecio Just checking on when are you planning to push a new release which includes above changes?

@benbuzbee benbuzbee mentioned this pull request Apr 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gallaecio Gallaecio Gallaecio approved these changes

@serhii73 serhii73 serhii73 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is there a PREFER_MONTH_OF_YEAR also?
4 participants
@adnan-awan @anuj1508 @Gallaecio @serhii73