Use the new HttpResponse that replaces ResponseData in web_poet #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference PR from web_poet: scrapinghub/web-poet#30
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=======================================
Coverage 95.96% 95.96%
=======================================
Files 9 9
Lines 372 372
=======================================
Hits 357 357
Misses 15 15
|
kmike
reviewed
Mar 28, 2022
kmike
reviewed
Mar 28, 2022
kmike
reviewed
Mar 28, 2022
kmike
reviewed
Mar 28, 2022
11 tasks
kmike
reviewed
Apr 28, 2022
kmike
reviewed
May 6, 2022
|
|
||
| """Build a ``web_poet.HttpResponse`` instance using a Scrapy ``Response``""" | ||
| return [ | ||
| HttpResponse( |
There was a problem hiding this comment.
Suggested change
| HttpResponse( | |
| web_poet.HttpResponse( |
kmike
reviewed
May 6, 2022
kmike
reviewed
May 6, 2022
| response_data["url"], | ||
| response_data["body"], | ||
| status=response_data["status"], | ||
| headers=HttpResponseHeaders.from_bytes_dict(response_data["headers"]), |
There was a problem hiding this comment.
Why is HttpResponseHeaders.from_bytes_dict needed here?
There was a problem hiding this comment.
@kmike It's because Scrapy headers look like this:
scrapy_headers = {
b"Content-Encoding": [b"gzip", b"br"],
b"Content-Type": [b"text/html"],
b"content-length": b"648",
}Reference for the motivation: scrapinghub/web-poet#33 (comment)
There was a problem hiding this comment.
If I'm not wrong, here the result is not coming from Scrapy, it's a part of serialization / deserialization for cache.
kmike
approved these changes
May 6, 2022
Co-authored-by: Mikhail Korobov <kmike84@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference PR from
web_poet: scrapinghub/web-poet#30.This also uses the small enhancement in scrapinghub/web-poet#33.
Checklist before release:
setup.pyandtox.inithat prevents breaking the CI on this PR