Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update browser_tab.py #426

Open
wants to merge 16 commits into
base: master
Choose a base branch
from
Open

Update browser_tab.py #426

wants to merge 16 commits into from

Conversation

Japan10
Copy link

@Japan10 Japan10 commented Mar 24, 2016

Line: 915
Change "user-agent" to "User-Agent"

Line:915
Change "user-agent" to "User-Agent"
@codecov-io
Copy link

Current coverage is 85.62%

Merging #426 into master will decrease coverage by -0.09% as of 7355a3b

@@            master    #426   diff @@
======================================
  Files           39      39       
  Stmts         4627    4627       
  Branches       633     633       
  Methods          0       0       
======================================
- Hit           3966    3962     -4
- Partial        156     159     +3
- Missed         505     506     +1

Review entire Coverage Diff as of 7355a3b

Powered by Codecov. Updated on successful CI builds.

@dvdbng
Copy link
Contributor

dvdbng commented Mar 24, 2016

Hi @Genius001 thanks for the pull request! There are some test failing because they have "user-agent" instead of "User-Agent" hardcoded in them, would you mind fixing that as well?

@Japan10
Copy link
Author

Japan10 commented Mar 24, 2016

Hi, @Youwotma

I noticed if change all 'user-agent' to 'User-Agent' in tests/test_execute.py that will cause another problem, And test will failing.

The error log https://travis-ci.org/scrapinghub/splash/jobs/118187194#L2146

I could not figure out how to resolve it.
If I fix all these headers key(cache-control, accept-encoding,accept-language) to case sensitive.
That could be affect other test file?

But this time I thought whether is it necessary to do this or keep original?

If it is necessary, workaround?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants