FailedWhenContains with SendWithCallbacks #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 hey @shaazmik -- seems reasonable to me! I pushed some commits to shut up the linter and update/add a test case for this. if that looks good to you we can get this merged! thanks for the work on this! 🚀 |
|
Thank you! My mistake for not adding the tests, for some reason it failed to run the linter for PR. Best wishes |
|
no worries at all, thanks for the work here! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Greetings. I was able to implement full pagination support for devices where it is not possible to disable it. However, for full coverage, there was not enough option for SendWithCallbacks to be able to handle invalid commands. Then we can consider that it is safe to implement pagination through the library.
I know that it is possible to write a Callback to detect an incorrect command, but for this purpose I had to use low-level primitives of the library, such as queues inside driver channels.
Thanks.