note that SPLASH_SLOT_POLICY value isn't a string #157
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put a little note about what value should
SPLASH_SLOT_POLICY
setting have.I want this moment to be noted in
README.rst
because it's a little confusing at first, when you need to import something insettings.py
while Scrapy needs only string paths to mentioned objects.I think it would be better to refactor how plugin processes settings to import needed object itself, but not inside
settings.py
to keep Scrapy's style.