Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use a copy instead of changing external dict #164

Merged
merged 1 commit into from
Feb 2, 2018

Conversation

whalebot-helmsman
Copy link
Contributor

No description provided.

@codecov
Copy link

codecov bot commented Feb 2, 2018

Codecov Report

Merging #164 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #164      +/-   ##
==========================================
+ Coverage   92.66%   92.67%   +0.01%     
==========================================
  Files           9        9              
  Lines         586      587       +1     
  Branches      118      118              
==========================================
+ Hits          543      544       +1     
  Misses         21       21              
  Partials       22       22
Impacted Files Coverage Δ
scrapy_splash/request.py 94.64% <100%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857f549...6658431. Read the comment docs.

Copy link
Contributor

@iAnanich iAnanich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just simple

@kmike
Copy link
Member

kmike commented Feb 2, 2018

Thanks @whalebot-helmsman!

@kmike kmike merged commit f05c870 into scrapy-plugins:master Feb 2, 2018
kmike added a commit that referenced this pull request Feb 5, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants