Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pre commit #125

Merged
merged 15 commits into from
Nov 7, 2024
Merged

Conversation

emarondan
Copy link

  • added config files for pre-commit hooks
  • excluding bandit checks and test dir
  • added pre-commit to github CI checks
  • running pre-commit hooks for all the code

@@ -1,4 +1 @@
from .middleware import ZyteSmartProxyMiddleware
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not good.

The “unused import” thing should generally be ignored in the main __init__.py of a package, where we usually put imports to make it easier for people to import them, e.g. from scrapy_zyte_smartproxy import ZyteSmartProxyMiddleware instead of from scrapy_zyte_smartproxy.middleware import ZyteSmartProxyMiddleware.

@Gallaecio
Copy link
Contributor

The error seems to be about a test expectation unrelated to your changes, but it would be nice to fix it before merging this, be it in this PR or in a separate one.

@emarondan
Copy link
Author

The error seems to be about a test expectation unrelated to your changes, but it would be nice to fix it before merging this, be it in this PR or in a separate one.

Ok, no problem.. I will fix it in this PR

@Gallaecio Gallaecio merged commit 93b1469 into scrapy-plugins:master Nov 7, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants