Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding pre commit #65

Merged
merged 5 commits into from
Apr 12, 2024
Merged

Adding pre commit #65

merged 5 commits into from
Apr 12, 2024

Conversation

emarondan
Copy link

  • added config files for pre-commit hooks
  • excluding bandit checks and test dir
  • added pre-commit to github CI checks
  • running pre-commit hooks for all the code

@Gallaecio
Copy link
Member

Looks like pylint and typing do not pass.

Not sure why the typing issues, I see mypy is frozen and you have not upgraded it, so in theory tests should pass. Let me know if you have a hard time figuring that one out and I’ll look into it myself.

pyproject.toml Outdated Show resolved Hide resolved
@Gallaecio Gallaecio merged commit b61206d into scrapy:master Apr 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants