Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

debian sysvinit script #41

Merged
merged 2 commits into from
Apr 28, 2014
Merged

debian sysvinit script #41

merged 2 commits into from
Apr 28, 2014

Conversation

nyov
Copy link
Contributor

@nyov nyov commented Mar 16, 2014

This is the custom initscript I use on my box,
this shouldn't affect ubuntu using the upstart script I think, but please build-test before merge as I have no Ubuntu to test on right now.

Then I saw these lintian warnings and tried fixing them:

W: scrapyd: copyright-refers-to-deprecated-bsd-license-file
P: scrapyd: copyright-with-old-dh-make-debian-copyright
E: scrapyd: description-starts-with-package-name
I: scrapyd: extended-description-is-probably-too-short
I: scrapyd: init.d-script-missing-lsb-description etc/init.d/scrapyd
E: scrapyd: init.d-script-missing-dependency-on-remote_fs etc/init.d/scrapyd: required-start
E: scrapyd: init.d-script-missing-dependency-on-remote_fs etc/init.d/scrapyd: required-stop
I: scrapyd: unused-override new-package-should-close-itp-bug
W: scrapyd-deploy: copyright-refers-to-deprecated-bsd-license-file
P: scrapyd-deploy: copyright-with-old-dh-make-debian-copyright
I: scrapyd-deploy: extended-description-is-probably-too-short

Not fixed are:

W: scrapyd-deploy: binary-without-manpage usr/bin/scrapyd-deploy
W: scrapyd: binary-without-manpage usr/bin/scrapyd

@pablohoffman
Copy link
Member

These changes look OK to me, what do you think @dangra?

@nyov
Copy link
Contributor Author

nyov commented Apr 26, 2014

I should mention, the change in package description was also to fix lintian's "description too short/long" warnings. I tried my best to formulate something but I don't mind reverting that -- or taking suggestions for something better.

dangra added a commit that referenced this pull request Apr 28, 2014
@dangra dangra merged commit 439f0c1 into scrapy:master Apr 28, 2014
@nyov nyov deleted the sysvinit branch April 29, 2014 01:58
@Digenis Digenis mentioned this pull request Jun 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants