API - Normalize block names with scratch-flash

[thisandagain]

We should normalize the block names with what exists in the scratch-flash codebase. This will make eventual work on the runtime / project serialization easier.

/cc @cwillisf @tmickel

[tmickel]

What block names are you referring to here?

[thisandagain]

In scratch-flash and our subsequent project JSON representation we have a keyword / "name" for each block. We should make sure our blocks implemented in blockly have a matching name as to make conversion between formats consistent / clear.

[RoboErikG]

Is the name the block type or a unique id for each block? Blockly currently has both--the name of the block type ('name') and a recently added uuid ('id').

[thisandagain]

Good question. In this case I'm referring to the block type. Example:

{
    "scripts": [
        [
            92,
            177,
            [
                [
                    "whenGreenFlag"
                ],
                [
                    "hide"
                ],
                [
                    "wait:elapsed:from:",
                    4.5
                ],
                [
                    "show"
                ],
                [
                    "lookLike:",
                    "LGTTM 1"
                ],
                [
                    "doRepeat",
                    34,
                    [
                        [
                            "wait:elapsed:from:",
                            0.4
                        ],
                        [
                            "nextCostume"
                        ]
                    ]
                ],
                [
                    "wait:elapsed:from:",
                    0.4
                ],
                [
                    "broadcast:",
                    "Venus"
                ],
                [
                    "hide"
                ]
            ]
        ]
    ]
}

[RoboErikG]

I checked again, we need to do some cleanup on Blockly side here (and I was wrong on the naming). We're currently using 'type' for this in the xml and 'id' in the json. We use 'name' consistently to identify fields and inputs.

[tmickel]

P.S. if you'd also like to normalize with the existing scratchjr blocks, see https://github.com/LLK/scratchjr/blob/master/src/editor/blocks/BlockSpecs.js

[RoboErikG]

Is that a private repo? We don't seem to have access.

[tmickel]

@RoboErikG yes, but it will be public soon :)