Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal Grammar - Standard Block - Reset #69

Closed
carljbowman opened this issue Feb 22, 2016 · 0 comments
Closed

Horizontal Grammar - Standard Block - Reset #69

carljbowman opened this issue Feb 22, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@carljbowman
Copy link

Illustrator File

R4_Standard Block.ai.zip

General Size / Icon

r4_standard-block size

Radii

r4_standard-block radii

@thisandagain thisandagain modified the milestone: March 31 Feb 29, 2016
@tmickel tmickel assigned tmickel and unassigned rschamp Feb 29, 2016
@tmickel tmickel closed this as completed Mar 1, 2016
picklesrus pushed a commit to picklesrus/scratch-blocks that referenced this issue Aug 4, 2017
…s, + menu bar (scratchfoundation#83)

* Covers parts of these issues: GUI layout panes (scratchfoundation#69), sprite libraries (scratchfoundation#12), import buttons (scratchfoundation#64), menu bar (scratchfoundation#67), and sprite info area (scratchfoundation#53)

~ Refactored layout pane structure by removing `display: flex` from `.box`, by default. Declaring flex instead only where specifically needed. This helped fix layout quirks, and should help us avoid hard to find issues related to nested flex boxes

~ Added descriptive classnames to boxes/containers/wrappers. Moved more padding, margins + layout into these wrappers to help with component reusability.

~ Set up a spacer unit variable inside `gui.css`, to start keeping consistent padding, margins and rounded corners between panes. Used [CSS/PostCSS Modules](https://github.com/css-modules/postcss-modules-values) to avoid SCSS dependency.

~ Refactored inline styles from JSX, into CSS files. 2 reasons: a) prepping for reuse of CSS Module variables. b) Feels easier to debug complex flex layouts when all the styles are in one place vs JS/HTML/CSS syntax mixed together

~ Added menu bar into layout via new component, and sprite info header in sprite selector pane, with stubs for the labels + forms. Sprite items are correctly scrolling, while leaving the header fixed, in Chrome. Mostly working in FFx. Not working in Safari, IE yet.

~ Style pass on library modal

~ Experimenting with a few different transition styles: Logo in menu bar, sprite library items, Add buttons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants