Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizontal Grammar - Event Cap with Dropdown Input - Broadcast Message #73

Closed
carljbowman opened this issue Feb 22, 2016 · 8 comments
Closed
Assignees
Labels
Milestone

Comments

@carljbowman
Copy link

Illustrator File

R4_Event Menu Cap.ai.zip

General Size / Icon

r4_event-menu-cap size

Radii

r4_event-menu-cap radii

Input Alignment

r4_event-menu-cap input

@tmickel
Copy link
Contributor

tmickel commented Feb 29, 2016

@carljbowman do you have a design in mind for the contents of the drop-down? Perhaps a small icon menu like ScratchJr would be good to start?

@tmickel tmickel assigned tmickel and unassigned rschamp Feb 29, 2016
@carljbowman
Copy link
Author

@tmickel - I will create a more robust spec, but in the mean time we should plan for ScratchJr-esque menu with small icons as variables.

@tmickel
Copy link
Contributor

tmickel commented Mar 7, 2016

It's feeling to me like we'll need to implement this as a fork of field_dropdown (e.g. field_dropdown_icons)

@tmickel
Copy link
Contributor

tmickel commented Mar 7, 2016

Not sure how to deal with implementing the icon menu. Could make one by hand or try to implement a closure MenuItemRenderer? But we're going to be styling the menu and not sure how possible that is with closure..

@carljbowman
Copy link
Author

If it is at all helpful, here is a very early sketch of menus. Pretty similar to ScratchJr but with Horizontal spacing and proportions.

screen shot 2016-03-07 at 1 11 16 pm

I need to do some further explorations with different amounts of items, especially when the number of items is not a multiple of 3. Also state of selected item is still being ironed out.

@tmickel
Copy link
Contributor

tmickel commented Mar 14, 2016

field_dropdown can take a goog.dom.createDom('img', {'src': ...}) as a parameter, but it breaks the rendering of the block...

@tmickel
Copy link
Contributor

tmickel commented Mar 18, 2016

Requires #128

@thisandagain thisandagain modified the milestones: April 21, March 24 Mar 25, 2016
@tmickel tmickel removed their assignment Apr 4, 2016
@kaschm kaschm added feature and removed design labels Apr 4, 2016
@tmickel
Copy link
Contributor

tmickel commented Apr 21, 2016

I believe this is all set!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants