Don't let blocks scroll over fixed flyout #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To do this, I draw the flyout relative to the SVG (instead of relative to the workspace view) and then resize the workspace view (absoluteLeft/Top and viewWidth/Height) to not include the flyout area.
|
This doesn't work, see the bug described on the upstream issue: google/blockly#352 |
thisandagain
pushed a commit
that referenced
this pull request
May 17, 2016
Replace the call to getBBox() in getMainWorkspaceMetrics
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To do this, I draw the flyout relative to the SVG (instead of relative
to the workspace view) and then resize the workspace view
(absoluteLeft/Top and viewWidth/Height) to not include the flyout area.
Fixes #275.