Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export for use on scratch-www #1336

Closed
rschamp opened this issue Jan 24, 2018 · 0 comments · Fixed by #1448
Closed

Export for use on scratch-www #1336

rschamp opened this issue Jan 24, 2018 · 0 comments · Fixed by #1448
Assignees
@chrisgarrity
Labels
enhancement
Milestone
April 2018

Comments

@rschamp
Copy link
Contributor

rschamp commented Jan 24, 2018 •
edited
Loading

In order to use the GUI on scratch-www we need to make some things importable:

  • Combined GUI reducer
  • scratch-paint reducer, separately from the GUI reducer
    • Since scratch-paint expects its state to be under state.scratchPaint, it must be combined with the gui reducer separately. Otherwise, when scratch-gui is embedded into scratch-www, the scratchPaint state will be under state.gui.scratchPaint, so things will break
    • We want to export this as a part of scratch-gui so that scratch-www doesn't need scratch-paint as a separate dependency
    • We will need to re-combine the gui and scratchPaint reducers for the GUI "playground" in this repo, which can serve as an example of how to combine the reducers in www
  • The GUI component
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chrisgarrity chrisgarrity

Labels
enhancement
Projects
None yet
Milestone
April 2018
Development

Successfully merging a pull request may close this issue.

Feature/untangle redux chrisgarrity/scratch-gui
3 participants
@chrisgarrity @thisandagain @rschamp