Feature/export for www #1425
Closed
Feature/export for www #1425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separate the GUI and scratchPaint reducers, and export both for combining by wrapping component. Change examples to import GUI from new index.js instead of from container.
Looks like something should happen with all the SVG and PNG outputs.
Question - do all of the modules need the same assets copies. If so can the plugins be part of the base? Apparently sometimes plugin order matters, and other times it doesn’t.
Move devServer into base to correctly set the port. Remove unneeded node version.
Merged
|
We've pretty much settled on not doing things this way, so closing this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves
FIxes #1336.
Proposed Changes
state.guiReason for Changes
Allows the GUI to be imported for use in scratch-www
Test Coverage
Current tests continue to run