feat(1958): Hapi v19 dependencies upgrade. BREAKING CHANGE: v19.x.x #108
Conversation
package.json
Outdated
| "screwdriver-data-schema": "git://github.com/screwdriver-cd/data-schema.git#hapi-v19", | ||
| "screwdriver-workflow-parser": "git://github.com/screwdriver-cd/workflow-parser.git#hapi-v19", |
test/index.test.js
Outdated
| @@ -124,7 +124,7 @@ describe('config parser', () => { | |||
| () => parser(loadData('bad-step-name.yaml')) | |||
| .then((data) => { | |||
| assert.match(data.jobs.main[0].commands[0].command, | |||
| /"foo bar" only supports the following characters A-Z,a-z,0-9,-,_/); | |||
| /foo bar" only supports the following characters A-Z,a-z,0-9,-,_/); | |||
There was a problem hiding this comment.
is this weird? why is it missing a leading quotation mark?
There was a problem hiding this comment.
The complete message is actually [Validation Error] "jobs.main.steps[0].foo bar" ..., so we are matching the pattern.
There was a problem hiding this comment.
shouldn't it have matched even with the "?
There was a problem hiding this comment.
Actual error message now includes the entire object structure.
ValidationError: "jobs.main.steps[0].foo bar" only supports the following characters A-Z,a-z,0-9,-,_
which is not a correct regex in itself. So made a limited change to message.
pritamstyz4ever
changed the title
lib/phase/structural.js
Outdated
| }) | ||
| ); | ||
| return data; | ||
| } catch (err) { |
There was a problem hiding this comment.
why is this catch needed ? can't the entire try..catch be omitted and let the function throw err
test/index.test.js
Outdated
| @@ -124,7 +124,7 @@ describe('config parser', () => { | |||
| () => parser(loadData('bad-step-name.yaml')) | |||
| .then((data) => { | |||
| assert.match(data.jobs.main[0].commands[0].command, | |||
| /"foo bar" only supports the following characters A-Z,a-z,0-9,-,_/); | |||
| /foo bar" only supports the following characters A-Z,a-z,0-9,-,_/); | |||
There was a problem hiding this comment.
shouldn't it have matched even with the "?
Context
Screwdriver hapi.js dependencies are outdated and not supported anymore.
Objective
This PR upgrades hapi and node fixes all schema related changes to be compatible with latest @Hapi js dependencies.
References
screwdriver-cd/screwdriver#1958
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.