feat(1958): Upgrade hapiv19 dependencies BREAKING CHANGE #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pritamstyz4ever
changed the title
adong
reviewed
Aug 21, 2020
| @@ -1,11 +1,11 @@ | |||
| { | |||
| "name": "screwdriver-executor-base", | |||
| "version": "5.2.0", | |||
| "version": "8.0.0", | |||
There was a problem hiding this comment.
I thought it ought to be 6.0.0? Then I checked releases, releases are on 7.5.x already. Never mind.
adong
reviewed
Aug 21, 2020
| @@ -28,7 +27,7 @@ const annotationRe = /screwdriver.cd\/(\w+)/; | |||
| * @return {Promise} | |||
| */ | |||
| async function validate(config, schema) { | |||
| const result = Joi.validate(config, schema); | |||
| const result = schema.validate(config); | |||
There was a problem hiding this comment.
This actually reads better (to me).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Upgrade to latest hapi js version v19 supported and stable version
Objective
This PR upgrades joi version to 17.x.x
References
screwdriver-cd/screwdriver#1958
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.