Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(293): type of previous meta to map[string]interface{} #110

Merged
merged 1 commit into from
Mar 9, 2017
Merged

fix(293): type of previous meta to map[string]interface{} #110

merged 1 commit into from
Mar 9, 2017

Conversation

tk3fftk
Copy link
Member

@tk3fftk tk3fftk commented Mar 9, 2017

Build.Meta is string and it caused JSON parse error when fetch previous Meta.

This PR provides:

  • The type of Build.Meta to map[string]interface{} from string.
  • Update tests for above fix.

Related:

d2lam
d2lam approved these changes Mar 9, 2017
View reviewed changes
Copy link
Member

@d2lam d2lam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch 👍

minzcmu
minzcmu approved these changes Mar 9, 2017
View reviewed changes
Copy link
Member

@minzcmu minzcmu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@minzcmu minzcmu merged commit d9eb73e into screwdriver-cd:master Mar 9, 2017
@tk3fftk tk3fftk deleted the fix-load-meta branch March 21, 2017 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minzcmu minzcmu minzcmu approved these changes

@d2lam d2lam d2lam approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tk3fftk @d2lam @minzcmu