feat: add SD_STEP_NAME env variable #439
Conversation
| executionCommand := []string{ | ||
| "export SD_STEP_ID=" + guid, | ||
| // escape not necessary because step name is limited to [A-Za-z0-9_-] | ||
| ";export SD_STEP_NAME=" + stepName, | ||
| ";. " + path, | ||
| ";echo", |
There was a problem hiding this comment.
Not related to my change, but I noticed that the commit introducing this 'echo' statement (2556c79 / #109) unintentionally broke the status check on the next line ($? comes from echo rather than from source).
It shouldn't really make a difference (i.e. echo guid $? would be skipped because of set -e if the user code results in anything other than success). But it's not the original intent of the code (and confusing). It should either just be echo 0 (because we know the line will only ever be reached on success) or something like "; printf \\\\n " + guid + " $?\n" and the extraneous echo removed.
If you have a preferred fix among those options, I am happy to send a separate pr.
There was a problem hiding this comment.
sure, u can use that printf or echo, whichever can wrap a newline before and after will do
| executionCommand := []string{ | ||
| "export SD_STEP_ID=" + guid, | ||
| // escape not necessary because step name is limited to [A-Za-z0-9_-] |
There was a problem hiding this comment.
Context
As a user, I want to access the current step name from code executing within the step.
Objective
Add new environment variable SD_STEP_NAME set before each ordinary step is executed run. Only set for ordinary user steps, not setup or teardown commands (during teardown, SD_STEP_NAME would be set to the last successfully executed step). If desired I could change this behavior.
References
License
I confirm that this contribution is made under the terms of the license found in the root directory of this repository's source tree and that I have the authority necessary to make this contribution on behalf of its copyright owner.