[SERF-2971] Instrument AWS clients using aws-sdk-go version 2
#105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neurostep
force-pushed
the
maksimt/SERF-2971/aws-sdk-go-v2
branch
2 times, most recently
from
bec91fe to
74bf117
Compare
Neurostep
force-pushed
the
maksimt/SERF-2971/aws-sdk-go-v2
branch
from
74bf117 to
4ae9688
Compare
Neurostep
force-pushed
the
maksimt/SERF-2971/aws-sdk-go-v2
branch
from
4ae9688 to
3dd4aba
Compare
Neurostep
force-pushed
the
maksimt/SERF-2971/aws-sdk-go-v2
branch
from
3dd4aba to
7b1f61b
Compare
laynax
previously approved these changes
Apr 23, 2024
Neurostep
force-pushed
the
maksimt/SERF-2971/aws-sdk-go-v2
branch
from
7b1f61b to
4d2597a
Compare
laynax
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In this PR we introduce a new AWS instrumentation function
InstrumentAWSClient. It uses aws-sdk-go-v2. The usage of theInstrumentAWSSessionmarked is deprecated.Additionally, we updated the
PubSubconfiguration to use AWS Config instead of the AWS session to support the migration to AWS SDK Go version 2.In this PR we keep AWS version 1 SDK to have a smooth transition to a AWS SDK Go version 2.
The usage of the AWS SDK Go version 1 will be cleaned up when we migrate all services.
Testing considerations
Tested these changes in
user-notifications-ingestionto confirm the AWS MSK authenticationChecklist
developmentand/orstagingREADME.mdas necessaryRelated links