-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DEVPLAT-1850] Add SQS support to PubSub #127
Conversation
504f95a
to
9a1909d
Compare
9a1909d
to
d2ae7ce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀 📜
I still think in case of an interrupt we will lose some messages mid way, but we can improve it in the future
d2ae7ce
to
aac5282
Compare
048282f
to
617cb65
Compare
Do you have something in particular in mind? I tested it with the service restart, and all looks 👌 In AWS SQS, if the message is not deleted from the queue, it will be re-queued again after the timeout (default |
Yeah but we better not to rely on the retention config. What I had in mind was something simple like having a waitgroup and returning from |
617cb65
to
ba9ce58
Compare
This is make sense and I think we can easily achieve this 👍 Please, check out the new version 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ba9ce58
to
720e682
Compare
Description
The MLD team is building the asynchronous architecture based on the AWS SQS and wants to integrate it into the Doc Chat service. We have to add the SQS PubSub interface to the go-sdk to support that.
In this PR we add support for SQS transport in our PubSub system:
NOTE
I stumbled into the problem with the AWS GO SDK v2 issue described here: aws/aws-sdk-go-v2#2370
The solution is to upgrade the
aws-sdk-go-v2
and all dependent packages to the latest version. I didn't notice any other breaking changes that we should take care of. Eventually, we will upgrade Chassis services using Parity workflowTesting considerations
Checklist
development
and/orstaging
README.md
as necessaryRelated links