Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests to PR Checks for Scribe Android #195

Closed
2 tasks done
albendz opened this issue Oct 13, 2024 · 4 comments
Closed
2 tasks done

Add unit tests to PR Checks for Scribe Android #195

albendz opened this issue Oct 13, 2024 · 4 comments
Assignees
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed

Comments

@albendz
Copy link
Contributor

albendz commented Oct 13, 2024

Terms

Description

Summary

Unit tests can be run with commands ./gradlew test or ./gradlew check. Note that the check task will also run other things like detekt. This issue tracks adding running these commands as part of PR checks.

This will be added to the ./github/workflows folder with the other PR workflows.

One question is whether the unit tests should be merged with the ktlint PR workflow or kept separate.

Contribution

I can work on this one. Feel free to assign to me with the recommendation on whether to merge this with the detekt PR workflow or have separate.

@albendz albendz added the feature New feature or request label Oct 13, 2024
@andrewtavis andrewtavis added help wanted Extra attention is needed hacktoberfest Included as a part of Hacktoberfest labels Oct 13, 2024
@albendz
Copy link
Contributor Author

albendz commented Oct 17, 2024

I can pick this one up!

@andrewtavis
Copy link
Member

Thanks for picking it up, @albendz! :) :)

@Linfye
Copy link
Collaborator

Linfye commented Oct 30, 2024

@andrewtavis Can this issue be closed by #209? 😊

@andrewtavis
Copy link
Member

Can be, yes @Linfye :) Thanks for the note and for the contributions, @albendz!

@github-project-automation github-project-automation bot moved this from Todo to Done in Scribe Board Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request hacktoberfest Included as a part of Hacktoberfest help wanted Extra attention is needed
Projects
Archived in project
Development

No branches or pull requests

3 participants