-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add unit testing dependencies #188
Conversation
Add Junit 5 and Mockk test dependencies with simple test
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @albendz. Everything looks good to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, @albendz! Really great to have the testing setup for Scribe-Android progressing so early on in its life 😊 Would be great if you could make the issues you discussed in the commit message!
Thanks so much, @albendz! Really amazing 😊 |
Add Junit 5 and Mockk test dependencies with simple test
Contributor checklist
Description
This change adds dependencies to enable writing unit tests including JUnit 5, a dependency to support use of JUnit 5 for android tests, and MockK following details and discussion from #181
I added a simple test for a utility class as an example.
I ran the following commands to test:
./gradlew test
./gradlew check
For each of these, I verified they fail when expected (set assertions to be incorrect) and pass otherwise.
Once this change is merged, there are a few follow ups needed - I can create issues for these so they can be done later:
Related issue