Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial state (on app install) of dark mode toggle. #304

Conversation

janiceferns02
Copy link
Contributor

Contributor checklist


Description

Correct the initial state of the dark mode toggle button to match the device's system dark mode preference on first launch.

Tested on device with both dark mode and light mode enabled in system settings and verified that the dark mode toggle button now correctly matches the system preference on app launch.
Also tested that the toggle button updates when the user changes the dark mode setting within the app.

Related issue

Copy link

github-actions bot commented Jan 24, 2025

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

@angrezichatterbox, would you be able to take a look at this? Maybe @mnzoidi as well? :)

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look great to me, @janiceferns02. Thanks for resolving the issue. I hope we can see you resolve more issues for Scribe. I think it’s a good for merge @andrewtavis

@angrezichatterbox angrezichatterbox linked an issue Jan 25, 2025 that may be closed by this pull request
2 tasks
@andrewtavis
Copy link
Member

Thanks for the review, @angrezichatterbox! And thanks also for the continued great work in the community, @janiceferns02! 😊

@andrewtavis andrewtavis merged commit 518a9f1 into scribe-org:main Jan 25, 2025
4 checks passed
@janiceferns02
Copy link
Contributor Author

Thanks! It feels great to see the issue is resolved and the PR merged. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dark mode button
3 participants