Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Case annotations suggestions for the keyboard #306

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

angrezichatterbox
Copy link
Member

Contributor checklist


Description

Through this PR we would be getting the case annotations suggestions in the Scribe-Android keyboard. I have also changed the border radius of the auto suggest keys for gender and case annotations to be more similar to Scribe-iOS.

Related issue

Copy link

github-actions bot commented Feb 3, 2025

Thank you for the pull request! ❤️

The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider attending our bi-weekly Saturday dev syncs. It'd be great to meet you 😊

Copy link

github-actions bot commented Feb 3, 2025

Maintainer Checklist

The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@angrezichatterbox
Copy link
Member Author

I will fix these linting issues in some time.

Should I within the same PR reference the Command bar place holder text from the interface variables.

@andrewtavis
Copy link
Member

Would be great if that could be included, @angrezichatterbox 😊 Thanks for the great work here so far!

@angrezichatterbox
Copy link
Member Author

Would be great if that could be included, @angrezichatterbox 😊 Thanks for the great work here so far!

I will make those changes and sent in the updated PR by tomorrow evening

@angrezichatterbox angrezichatterbox force-pushed the feature/Case-Annotations-For-Prepositions branch 2 times, most recently from 5ed6540 to d789836 Compare February 4, 2025 07:50
@andrewtavis
Copy link
Member

Anything else needed here, @angrezichatterbox? :)

@angrezichatterbox
Copy link
Member Author

Anything else needed here, @angrezichatterbox? :)

Some small changes are required and it would be ready for review.

@andrewtavis
Copy link
Member

Quick heads up that this branch has merge conflicts now that #305 has been brought in, @angrezichatterbox :)

@angrezichatterbox angrezichatterbox force-pushed the feature/Case-Annotations-For-Prepositions branch 2 times, most recently from 8288340 to c8f3d7a Compare February 4, 2025 13:05
@angrezichatterbox
Copy link
Member Author

I will fix a few more bugs and sent in here if it's ready for review.

@andrewtavis
Copy link
Member

Sure thing, @angrezichatterbox! Let me know when to check it all out :)

@angrezichatterbox angrezichatterbox force-pushed the feature/Case-Annotations-For-Prepositions branch from c8f3d7a to fe1ee3d Compare February 4, 2025 15:17
@angrezichatterbox
Copy link
Member Author

It is ready for review. I have adjusted the border radius of the suggest button a bit based on how I saw it on Scribe-iOS. Would love to make any changes to make the PR perfect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants