-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Case annotations suggestions for the keyboard #306
base: main
Are you sure you want to change the base?
Implement Case annotations suggestions for the keyboard #306
Conversation
Thank you for the pull request! ❤️The Scribe-Android team will do our best to address your contribution as soon as we can. If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the |
Maintainer ChecklistThe following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) |
I will fix these linting issues in some time. Should I within the same PR reference the Command bar place holder text from the interface variables. |
Would be great if that could be included, @angrezichatterbox 😊 Thanks for the great work here so far! |
I will make those changes and sent in the updated PR by tomorrow evening |
5ed6540
to
d789836
Compare
Anything else needed here, @angrezichatterbox? :) |
Some small changes are required and it would be ready for review. |
Quick heads up that this branch has merge conflicts now that #305 has been brought in, @angrezichatterbox :) |
8288340
to
c8f3d7a
Compare
I will fix a few more bugs and sent in here if it's ready for review. |
Sure thing, @angrezichatterbox! Let me know when to check it all out :) |
c8f3d7a
to
fe1ee3d
Compare
It is ready for review. I have adjusted the border radius of the suggest button a bit based on how I saw it on Scribe-iOS. Would love to make any changes to make the PR perfect. |
Contributor checklist
./gradlew lintKotlin detekt test
command as directed in the testing section of the contributing guideDescription
Through this PR we would be getting the case annotations suggestions in the Scribe-Android keyboard. I have also changed the border radius of the auto suggest keys for gender and case annotations to be more similar to Scribe-iOS.
Related issue