Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Application identifier #49

Merged

Conversation

angrezichatterbox
Copy link
Member

@angrezichatterbox angrezichatterbox commented Jul 27, 2024

Description

The pull request changes the application identifier from org.scribe to be.scri.

Related issue

  1. For some reason the old method of checking of whether it was a new user and telling the user to go to settings didn't seem to work so I had to make the check using the package name of those input picker additions. Should I revert that change. ?

Copy link

github-actions bot commented Jul 27, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis andrewtavis self-requested a review July 27, 2024 17:57
@andrewtavis
Copy link
Member

Hey @angrezichatterbox 👋

For some reason the old method of checking of whether it was a new user and telling the user to go to settings didn't seem to work so I had to make the check using the package name of those input picker additions. Should I revert that change. ?

We actually discussed in the sync today, and we would prefer for the app to not force the user to install a keyboard. We'll direct them to install the keyboard on the installation page, and keyboard settings will be conditional on them being installed. It should be ok to revert that change so that the app opens without the tooltip telling the user to install the keyboard. Can you remove the code for that?

@angrezichatterbox angrezichatterbox force-pushed the feat/Change-application-id branch from e0b6d7a to 302466a Compare July 28, 2024 02:27
@angrezichatterbox
Copy link
Member Author

Hey @angrezichatterbox 👋

For some reason the old method of checking of whether it was a new user and telling the user to go to settings didn't seem to work so I had to make the check using the package name of those input picker additions. Should I revert that change. ?

We actually discussed in the sync today, and we would prefer for the app to not force the user to install a keyboard. We'll direct them to install the keyboard on the installation page, and keyboard settings will be conditional on them being installed. It should be ok to revert that change so that the app opens without the tooltip telling the user to install the keyboard. Can you remove the code for that?

I have reverted the change.

@andrewtavis
Copy link
Member

Checking it right now :) On build I'm getting the following error:

Activity class {org.scribe.debug/be.scri.activities.SplashActivity.Orange} does not exist

Maybe there's a spot where it's still org.scribe in the code?

@angrezichatterbox
Copy link
Member Author

Checking it right now :) On build I'm getting the following error:

Activity class {org.scribe.debug/be.scri.activities.SplashActivity.Orange} does not exist

Maybe there's a spot where it's still org.scribe in the code?

I have replaced it now in the latest commit to wherever I found org.scribe. I'm sorry that I didn't check again. the refractor of Android Studio does not change it everywhere. Could you try to invalidate the cache and rebuild it as I am not able to replicate the same error.

@andrewtavis
Copy link
Member

Sure, will do a little later today, @angrezichatterbox!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still getting the requirement to install a keyboard at the start, but it's all good for now. We can make an issue for that specifically :)

Invalidating the cache did get rid of the error :) Thanks for this, @angrezichatterbox! 😊

@andrewtavis andrewtavis merged commit 6421f8f into scribe-org:main Jul 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants