-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change Application identifier #49
Change Application identifier #49
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Hey @angrezichatterbox 👋
We actually discussed in the sync today, and we would prefer for the app to not force the user to install a keyboard. We'll direct them to install the keyboard on the installation page, and keyboard settings will be conditional on them being installed. It should be ok to revert that change so that the app opens without the tooltip telling the user to install the keyboard. Can you remove the code for that? |
e0b6d7a
to
302466a
Compare
I have reverted the change. |
Checking it right now :) On build I'm getting the following error:
Maybe there's a spot where it's still |
I have replaced it now in the latest commit to wherever I found org.scribe. I'm sorry that I didn't check again. the refractor of Android Studio does not change it everywhere. Could you try to invalidate the cache and rebuild it as I am not able to replicate the same error. |
Sure, will do a little later today, @angrezichatterbox! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still getting the requirement to install a keyboard at the start, but it's all good for now. We can make an issue for that specifically :)
Invalidating the cache did get rid of the error :) Thanks for this, @angrezichatterbox! 😊
Description
The pull request changes the application identifier from org.scribe to be.scri.
Related issue
Switch app identifier to be.scri from org.scribe #42
Additional information