Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Autosuggest emojis menu item #81

Merged
merged 2 commits into from
Sep 6, 2024

Conversation

Linfye
Copy link
Collaborator

@Linfye Linfye commented Sep 6, 2024

Contributor checklist


Description

This PR add an menu item to trigger emoji autosuggestions and a Toast message while switching.

Related issue

Copy link

github-actions bot commented Sep 6, 2024

Thank you for the pull request!

The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :)

If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you!

Maintainer checklist

  • The commit messages for the remote branch should be checked to make sure the contributor's email is set up correctly so that they receive credit for their contribution

    • The contributor's name and icon in remote commits should be the same as what appears in the PR
    • If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for git config user.email in their local Scribe-Android repo
  • The linting and formatting workflows within the PR checks do not indicate new errors in the files changed

  • The CHANGELOG has been updated with a description of the changes for the upcoming release and the corresponding issue (if necessary)

@andrewtavis
Copy link
Member

Thanks for fixing the linting errors, @Linfye!

Copy link
Member

@angrezichatterbox angrezichatterbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the work @Linfye. The PR is quite good :). A Toast Message that shows up on the change of the Switch. @andrewtavis is this needed to indicate the change along with the Switch changing?

@andrewtavis
Copy link
Member

@angrezichatterbox, I don't think it hurts to have it in there :) We can remove it in #66 :)

@angrezichatterbox
Copy link
Member

@angrezichatterbox, I don't think it hurts to have it in there :) We can remove it in #66 :)

True, I just wanted to clarify whether it should be added to the other switch as well.

@andrewtavis
Copy link
Member

Yes I was thinking the same. If having them in there would give people a head start on future implementations of the menu options, then feel free to send along a PR to add the toasts, @angrezichatterbox :)

@angrezichatterbox
Copy link
Member

Yes I was thinking the same. If having them in there would give people a head start on future implementations of the menu options, then feel free to send along a PR to add the toasts, @angrezichatterbox :)

Yes, it would give some idea about what the change should be for each language and more clarity during development. Should I make the change to the other switch and add to this PR.

@andrewtavis
Copy link
Member

Sure thing, @angrezichatterbox! Sounds perfect. I'll bring this in after.

@angrezichatterbox
Copy link
Member

angrezichatterbox commented Sep 6, 2024

It seems I don't have permission to add to this PR. Should i add it to my other PR.

@andrewtavis
Copy link
Member

Ya I was worried about that. You can add it to your other PR :)

@andrewtavis
Copy link
Member

Or I'll merge in that one soon. Feel free to open a new one, @angrezichatterbox!

Copy link
Member

@andrewtavis andrewtavis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great contribution, @Linfye! Really seems like you're starting to get the hang of Scribe-Android 😊 Awesome to see!

@andrewtavis andrewtavis merged commit 412bcb5 into scribe-org:main Sep 6, 2024
1 check passed
@Linfye Linfye deleted the emoji-autosuggetions-menu-item branch September 7, 2024 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants