-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Autosuggest emojis menu item #81
Add Autosuggest emojis menu item #81
Conversation
Thank you for the pull request!The Scribe team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Android rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
Thanks for fixing the linting errors, @Linfye! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the work @Linfye. The PR is quite good :). A Toast Message that shows up on the change of the Switch. @andrewtavis is this needed to indicate the change along with the Switch changing?
@angrezichatterbox, I don't think it hurts to have it in there :) We can remove it in #66 :) |
True, I just wanted to clarify whether it should be added to the other switch as well. |
Yes I was thinking the same. If having them in there would give people a head start on future implementations of the menu options, then feel free to send along a PR to add the toasts, @angrezichatterbox :) |
Yes, it would give some idea about what the change should be for each language and more clarity during development. Should I make the change to the other switch and add to this PR. |
Sure thing, @angrezichatterbox! Sounds perfect. I'll bring this in after. |
It seems I don't have permission to add to this PR. Should i add it to my other PR. |
Ya I was worried about that. You can add it to your other PR :) |
Or I'll merge in that one soon. Feel free to open a new one, @angrezichatterbox! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great contribution, @Linfye! Really seems like you're starting to get the hang of Scribe-Android 😊 Awesome to see!
Contributor checklist
Description
This PR add an menu item to trigger emoji autosuggestions and a Toast message while switching.
Related issue