Fix IsPersistent and MarkAsNoLongerNeeded() using the wrong natives #907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #906
This changes the
IsPersistentsetter to executeMarkAsNoLongerNeeded()instead of the nativeSET_ENTITY_AS_MISSION_ENTITYwhen passedfalse.This also removed the
SET_ENTITY_AS_MISSION_ENTITYnative call fromMarkAsNoLongerNeeded(), as all it was doing was marking and then un-marking the entity as a mission entity.The original changes were made in this commit, where it was incorrectly assumed that the
SET_ENTITY_AS_MISSION_ENTITYnative could also make an entity non-persistent.