Add support for no downtime migrations #17
Conversation
| @@ -1,6 +1,6 @@ | |||
| cabal-version: 1.18 | |||
| name: hpqtypes-extras | |||
| version: 1.6.3.0 | |||
| version: 1.7.0.0 | |||
There was a problem hiding this comment.
We should also update CHANGELOG.md
| , tblInitialSetup :: Maybe TableInitialSetup | ||
| tblName :: RawSQL () -- ^ Must be in lower case. | ||
| , tblVersion :: Int32 | ||
| , tblAcceptedDbVersions :: [Int32] |
There was a problem hiding this comment.
I think there should be a Haddock comment explaining what this field is for.
| @@ -11,16 +15,47 @@ import Prelude | |||
| data Check = Check { | |||
| chkName :: RawSQL () | |||
| , chkCondition :: RawSQL () | |||
| , chkValidated :: Bool | |||
There was a problem hiding this comment.
I don't see any place where chkValidated is used (except initialisation), is it supposed to be useful to clients?
| @@ -22,6 +25,7 @@ data ForeignKey = ForeignKey { | |||
| , fkOnDelete :: ForeignKeyAction | |||
| , fkDeferrable :: Bool | |||
| , fkDeferred :: Bool | |||
| , fkValidated :: Bool | |||
There was a problem hiding this comment.
Similarly to chkValidated, I don't see any actual uses of fkValidated. If clients are supposed to use this field, it should have a Haddock comment.
| @@ -29,6 +31,7 @@ data TableIndex = TableIndex { | |||
| idxColumns :: [RawSQL ()] | |||
| , idxMethod :: IndexMethod | |||
| , idxUnique :: Bool | |||
| , idxValid :: Bool | |||
There was a problem hiding this comment.
Same comment as above: the library doesn't make use of idxValid, if the clients are supposed to, there should be a Haddock comment.
| @@ -1,6 +1,6 @@ | |||
| cabal-version: 1.18 | |||
| name: hpqtypes-extras | |||
| version: 1.6.3.0 | |||
| version: 1.7.0.0 | |||
|
I pushed a commit with explanations of new fields. |
|
OK, I'll cut a release today. |
|
Release 1.7.0.0 uploaded to Hackage. |
No description provided.