Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dep): upgrade go kzg 4844 #714

Closed
wants to merge 6 commits into from
Closed

Conversation

z2trillion
Copy link
Member

@z2trillion z2trillion commented Apr 21, 2024

1. Purpose or design rationale of this PR

upgrade the go-kzg-4844 dependency to version 1.0.0.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@z2trillion z2trillion changed the base branch from tload-tstore to develop April 21, 2024 02:20
@0xmountaintop
Copy link
Member

is this PR still a draft?

@icemelon icemelon changed the title Feat/upgrade go kzk 4844 Feat/upgrade go kzg 4844 Apr 23, 2024
@0xmountaintop 0xmountaintop marked this pull request as ready for review April 23, 2024 03:08
@0xmountaintop 0xmountaintop changed the title Feat/upgrade go kzg 4844 chore(dep): upgrade go kzg 4844 Apr 23, 2024
0xmountaintop
0xmountaintop previously approved these changes Apr 23, 2024
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
@z2trillion
Copy link
Member Author

A lot more changes were needed to fix the build, so I made a new PR here: #718. I will close this one if 718 is preferred.

@Thegaram
Copy link

Superseded by #718.

@Thegaram Thegaram closed this Apr 24, 2024
@0xmountaintop 0xmountaintop deleted the feat/upgrade_go-kzk-4844 branch April 24, 2024 03:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants