forked from ethereum/go-ethereum
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dep): upgrade go kzg 4844 #714
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
is this PR still a draft? |
0xmountaintop
changed the title
Feat/upgrade go kzg 4844
chore(dep): upgrade go kzg 4844
Apr 23, 2024
0xmountaintop
force-pushed
the
feat/upgrade_go-kzk-4844
branch
from
April 23, 2024 03:15
23179e1
to
cd4f8ab
Compare
0xmountaintop
previously approved these changes
Apr 23, 2024
Thegaram
reviewed
Apr 23, 2024
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
A lot more changes were needed to fix the build, so I made a new PR here: #718. I will close this one if 718 is preferred. |
Superseded by #718. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
upgrade the go-kzg-4844 dependency to version 1.0.0.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.go
been updated?4. Breaking change label
Does this PR have the
breaking-change
label?