Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: keep track of and export total time observed by a timer #772

Merged
merged 2 commits into from
May 27, 2024

Conversation

omerfirmak
Copy link

1. Purpose or design rationale of this PR

Pipeline uses Timer to keep track of how long each event took. But we also need to be able to have an aggregate value that represents how much of runtime a certain event occupied. There is timer.Sum()but that gets reset after some number of events, depending on how often we flush to influxdb, it might mess with our metrics.

This is not the most ideal way of doing this, but I will try to fix it upstream first before making big changes here.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@omerfirmak omerfirmak merged commit dd7f747 into develop May 27, 2024
@omerfirmak omerfirmak deleted the omerfirmak/timer-total branch May 27, 2024 06:46
0xmountaintop added a commit that referenced this pull request Aug 1, 2024
feature: keep track of and export total time observed by a timer (#772)

Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants