feat: implement RIP-7212/EIP-7212 #798
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerfirmak
approved these changes
Jun 5, 2024
Thegaram
approved these changes
Jun 5, 2024
jonastheis
changed the title
|
Congrats for the very fast progress! Looking forward to see full integration with circuits and then in mainnet 🚀 |
0xmountaintop
pushed a commit
that referenced
this pull request
Jul 30, 2024
Implement RIP-7212/EIP-7212 according to reference implementation at ulerdogan#1 Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
0xmountaintop
added a commit
that referenced
this pull request
Jul 30, 2024
feat: implement RIP-7212/EIP-7212 (#798) Implement RIP-7212/EIP-7212 according to reference implementation at ulerdogan#1 Co-authored-by: Jonas Theis <4181434+jonastheis@users.noreply.github.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Purpose or design rationale of this PR
This PR implements RIP-7212 (aka EIP-7212).
It follows the reference implementation of the author @ulerdogan ethereum#27540 and the more up-to-date version ulerdogan#1.
As discussed here ethereum-optimism/op-geth#168 (comment), there are additional tests added from https://github.com/google/wycheproof.
2. PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
3. Deployment tag versioning
Has the version in
params/version.gobeen updated?4. Breaking change label
Does this PR have the
breaking-changelabel?