Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sync l1msg fix from develop branch #826

Merged
merged 2 commits into from
Jun 13, 2024
Merged

fix: sync l1msg fix from develop branch #826

merged 2 commits into from
Jun 13, 2024

Conversation

0xmountaintop
Copy link

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Thegaram and others added 2 commits June 13, 2024 20:13
@Thegaram @0xmountaintop
fix: ensure L1 messages are stored in db consistently (#679)
f211808 
* fix: ensure L1 messages are stored in db consistently

* check db iterator errors
@colinlyguo @0xmountaintop
fix(sync-service): only add queue index when message index is not zero (
e9d1387 
#682)

* fix(sync-service): increase queue index only when L1 message index is not zero

---------

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

fix
@0xmountaintop 0xmountaintop merged commit bed81b0 into syncUpstream/active Jun 13, 2024
2 of 3 checks passed
@0xmountaintop 0xmountaintop deleted the syncUpstream/fix_l1msg branch June 13, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@0xmountaintop @Thegaram @colinlyguo