Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make descartes a timestamp based fork #852

Merged
merged 2 commits into from
Jun 26, 2024

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented Jun 24, 2024

1. Purpose or design rationale of this PR

simply changes IsDescartes to check the block time instead of height. I knowingly left out compatibility checks for timestamp based forks, since they will come with sync to upstream anyways.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@omerfirmak omerfirmak force-pushed the omerfirmak/timestamp-forks branch from a77ef78 to 55af836 Compare June 24, 2024 12:57
@0xmountaintop 0xmountaintop merged commit 50a6bc6 into develop Jun 26, 2024
8 checks passed
@0xmountaintop 0xmountaintop deleted the omerfirmak/timestamp-forks branch June 26, 2024 04:35
lwedge99 pushed a commit to sentioxyz/scroll-geth that referenced this pull request Aug 27, 2024
* feat: make descartes a timestamp based fork

* chore: auto version bump [bot]

---------

Co-authored-by: omerfirmak <omerfirmak@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants