feat: scroll parallel state root #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
greged93
force-pushed
the
feat/parallel-state-root
branch
from
a70ce81 to
1414d3d
Compare
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
frisitano
requested changes
Dec 23, 2024
There was a problem hiding this comment.
Looks good. Left a comment inline around packing nibbles. In scroll we use a bit representation for the key so when packing we should use the pack_bits method. I think the reason you don't catch it in the test is because you do not provide a TrieInput when invoking the ParallelStateRoot. Maybe you can add a test which sequentially computes the state root upon updates to state.
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
Signed-off-by: Gregory Edison <gregory.edison1993@gmail.com>
greged93
commented
Dec 23, 2024
frisitano
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the parallel state root computation to the state-commitment crate for live syncing root compute.