Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide for adding Canvas badges #333

Merged
merged 12 commits into from
Oct 15, 2024
Merged

Guide for adding Canvas badges #333

merged 12 commits into from
Oct 15, 2024

Conversation

isabellewei
Copy link
Contributor

No description provided.

Copy link

netlify bot commented Sep 6, 2024

Deploy Preview for scroll-documentation ready!

Name Link
🔨 Latest commit d29d1e8
🔍 Latest deploy log https://app.netlify.com/sites/scroll-documentation/deploys/670949947ab2bd0008be6645
😎 Deploy Preview https://deploy-preview-333.docs.scroll.xyz
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Sep 13, 2024

Hannah Shen left a comment:

Link to dev support should be changed to https://discord.com/invite/scroll

Browser metadata
Path:      /en/developers/guides/canvas-badge-integration/#step-1-badge-design-guidelines-design
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

Copy link

netlify bot commented Sep 13, 2024

Hannah Shen left a comment:

should we add API requirements in this doc too? Instead of redirecting to notion

Browser metadata
Path:      /en/developers/guides/canvas-badge-integration/#step-1-badge-design-guidelines-design
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

Copy link

netlify bot commented Sep 13, 2024

Hannah Shen left a comment:

Under Issuance method: Gifted and Back-end authorized both require API check. Sync on formatting and add that Gifted requires a Check API

Browser metadata
Path:      /en/developers/guides/canvas-badge-integration/#step-1-badge-design-guidelines-design
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

Copy link

netlify bot commented Sep 13, 2024

Hannah Shen left a comment:

Extra boost section: Unbold the content?

Browser metadata
Path:      /en/developers/guides/canvas-badge-integration/#reference-cors
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

Copy link

netlify bot commented Sep 13, 2024

Hannah Shen left a comment:

for Scroll Canvas - Anthropomorphic “assistants” Integration Guide for Developers https://www.notion.so/scrollzkp/Scroll-Canvas-Anthropomorphic-assistants-Integration-Guide-for-Developers-2712f7a91af042c0a2d145af804bab51 let's merge it here as well to smooth the flow?

Browser metadata
Path:      /en/developers/guides/canvas-badge-integration/#reference-cors
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

Copy link

netlify bot commented Sep 13, 2024

Hannah Shen left a comment:

Under Badge section, we can link EAS learning page for people get famimilar with Attestation https://scroll.easscan.org/learn/scroll

Browser metadata
Path:      /en/developers/guides/canvas-badge-integration/#reference-cors
Browser:   Chrome 128.0.0.0 on Mac OS 10.15.7
Viewport:  1642 x 810 @1x
Language:  en-US
Cookies:   Enabled

Open in BrowserStack

Open Deploy Preview · Mark as Resolved

fanyarachel and others added 4 commits September 23, 2024 17:28
* fix the title

* Unbold the text under toggle list
* fix the title

* Unbold the text under toggle list

* Update the content
Thegaram
Thegaram previously approved these changes Oct 3, 2024
Copy link
Contributor

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, just nitpicks.

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
* fix the title

* Unbold the text under toggle list

* Update the content

* update content based on the comments

---------

Co-authored-by: isabellewei <isabelle.wei@yahoo.ca>
@isabellewei isabellewei merged commit da760fa into develop Oct 15, 2024
6 checks passed
@isabellewei isabellewei deleted the isabellewei/canvas branch October 15, 2024 14:33
isabellewei added a commit that referenced this pull request Oct 15, 2024
* Darwinv2 changes (#332)

* darwinv2 changes

* oops

* note on reorgs and finality

* formatting

* added guide for the graph (#334)

* add alchemy to scroll tools

* update text in alchemy.mdx

* add 0x to dev tooling explorer

* fix feedback

* Guide for adding Canvas badges (#333)

* add Canvas guide

* fix

* add to nav

* display images side by side

* feedback

* add image margins

* fix the title (#337)

* Update the content detail and unbold text (#341)

* fix the title

* Unbold the text under toggle list

* Update the content (#348)

* fix the title

* Unbold the text under toggle list

* Update the content

* small edits

* Apply suggestions from code review

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* Isabellewei/canvas (#367)

* fix the title

* Unbold the text under toggle list

* Update the content

* update content based on the comments

---------

Co-authored-by: isabellewei <isabelle.wei@yahoo.ca>

---------

Co-authored-by: fanyarachel <43579854+fanyarachel@users.noreply.github.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

---------

Co-authored-by: AK <alikim@gmail.com>
Co-authored-by: Sahil Aujla <sahilaujla15@gmail.com>
Co-authored-by: emilyJLin95 <17280653+emilyJLin95@users.noreply.github.com>
Co-authored-by: Jessica Lin <jlin2700@gmail.com>
Co-authored-by: fanyarachel <43579854+fanyarachel@users.noreply.github.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants